How to code review without offending other developers [duplicate]

Posted by Justin984 on Programmers See other posts from Programmers or by Justin984
Published on 2013-10-07T14:26:13Z Indexed on 2013/10/23 22:05 UTC
Read the original article Hit count: 233

Filed under:

teamwork

|

code-reviews

|

professionalism

This question already has an answer here:

How to deal with someone who dislikes the idea of code reviews? 6 answers
How can I tactfully suggest improvements to others' badly designed code during review? 14 answers
How do I approach a coworker about his or her code quality? 12 answers

I work on a team that does frequent code reviews. But it seems like more of a formality than anything.

No one really points out problems in the code for fear of offending other developers. The few times I've tried to ask for changes were met with very defensive and reluctant attitudes.

This is of course not good. Not only are we spending the time to code review, but we're getting literally zero value from it. Is this an issue that needs to be addressed by individual developers, or are there techniques for suggesting changes without stepping on other people's toes?

© Programmers or respective owner

Related posts about teamwork

Teamwork 101 for the solo newbie

as seen on Programmers - Search for 'Programmers'
Forgive my newbishness but I have a question to ask about teamwork...mainly because I stink at it. Most of my projects up until this point have been solo so I have a very limited experience with teamwork. I did make graphics for a game that was being developed by several people, but that was completely… >>> More
How a student programmer improve his teamwork skill?

as seen on Stack Overflow - Search for 'Stack Overflow'
I am a student right now. Recently, I am working in a project as a leader with three other students. Due to the lack of experience, our project is progressing slowly and our members are frustrated. They do not feel sense of accomplishment in the project. I am pressured and frustrated, too. But as… >>> More
Q&A: Teamwork

as seen on Dr Dobbs - Search for 'Dr Dobbs'
It's all about trust and techniques United States - Organizations - Environment - Land Trusts - Health >>> More
How can a student programmer improve his teamwork skill?

as seen on Stack Overflow - Search for 'Stack Overflow'
I am a student right now. Recently, I am working in a project as a leader with three other students. Due to the lack of experience, our project is progressing slowly and our members are frustrated. They do not feel sense of accomplishment in the project. I am pressured and frustrated, too. But as… >>> More
Should Development / Testing / QA / Staging environments be similar?

as seen on Programmers - Search for 'Programmers'
Hi all, After much time and effort, we're finally using maven to manage our application lifecycle for development. We still unfortunately use ANT to build an EAR before deploying to Test / QA / Staging. My question is, while we made that leap forward, developers are still free to do as they please… >>> More

Related posts about code-reviews

How should code reviews be Carried Out?

as seen on Programmers - Search for 'Programmers'
My previous question has to do with how to advance code reviews among the developers. Here I am interested in how a code review session should be carried out, so that both the reviewer and reviewed are feeling comfortable with it. I have done some code reviews before and the experience has been… >>> More
How important is positive feedback in code reviews?

as seen on Programmers - Search for 'Programmers'
Is it important to point out the good parts of the code during a code review and the reasons why it is good? Positive feedback might be just as useful for the developer being reviewed and for the others that participate in the review. We are doing reviews using an online tool, so developers can open… >>> More
When to do code reviews when doing continuous integration?

as seen on Programmers - Search for 'Programmers'
We are trying to switch to a continuous integration environment but are not sure when to do code reviews. From what I've read of continuous integration, we should be attempting to check in code as often as multiple times a day. I assume, this even means for features that are not yet complete. So… >>> More
How to review code that you do not understand?

as seen on Programmers - Search for 'Programmers'
I have been given the role to improve development in our company. The first thing I wanted to start was code reviews since that has never been done here before. There are 3 programmers in our company. I am a web programmer, my known languages are mainly PHP, ActionScript and JavaScript. The other… >>> More
Are there code reviews in opensource projects? If so, what tools are used to do this?

as seen on Programmers - Search for 'Programmers'
I know there is a big push for code reviews in commercial development. However, are code reviews used in open source software or is based on trust? If so, then how are they performed? [Is it a delayed commit, "a pre commit environment", is there a tool that allows for the patch to be sent to another… >>> More